[Dev] code dumps without proper review

Ware, Ryan R ryan.r.ware at intel.com
Tue Oct 8 20:20:09 GMT 2013


If you’d like to handle this in a different way, please suggest a patch and it will be reviewed.


On Oct 8, 2013, at 4:13 AM, 조영익 <youngik.cho at samsung.com<mailto:youngik.cho at samsung.com>> wrote:

I found that major difference comes from https://review.tizen.org/gerrit/#/c/6033/ .

While this does not look any bad with the commit alone, it lacks the architectural review. To support the multi user, the relationship of AMD and launchpad should be addressed first. I posted a thread, Tizen 3.0 proposal for fixing OSP/WRT/Core hard-coded UID issue, and Mr. Sunil moved the mail to new mailing list.

I am very comfortable with existing commits except above one. Maybe my suggestion is not complete but any architectural decision should be addressed before changing existing multiuser-related changes. The current merge commit almost overwrites above change.


------- Original Message -------

Sender : Ylinen, Mikko<mikko.ylinen at intel.com<mailto:mikko.ylinen at intel.com>>

Date : 2013-10-08 19:36 (GMT+09:00)

Title : Re: Re: Re: [Dev] code dumps without proper review

On Tue, Oct 8, 2013 at 11:10 AM, 조영익 <youngik.cho at samsung.com<mailto:youngik.cho at samsung.com>> wrote:


On the merge commit, the following two files should be resurrected:



I understand that the location for SMACK manifest file is moved under packaging directory. However, there exists duplicated files of ac.service/ac_user.service and launchpad-preload at .service/launchpad-preload_user.service<mailto:launchpad-preload at .service/launchpad-preload_user.service>. I am not quite sure which of them are used in reality. Would you give me any clue, especially for IVI profile, please?

It looks *_user.service files are used if multiuser build config is enabled. IVI does not have that
enabled so we use ac.service and launchpad-preload at .service.



Dev mailing list
Dev at lists.tizen.org<mailto:Dev at lists.tizen.org>

More information about the Dev mailing list