[Dev] Proper SR Comments for OBS

Łukasz Stelmach l.stelmach at samsung.com
Fri Oct 25 08:01:26 GMT 2013

It was <2013-10-24 czw 17:59>, when Kanevskiy, Alexander wrote:
> On 10/24/13 10:40 , "Łukasz Stelmach" <l.stelmach at samsung.com> wrote:
>>It was <2013-10-23 śro 10:03>, when ANUJ MISHRA wrote:
>>> Dear Package Maintainers,
>>> Once you raise the SR, you should add proper & meaningful comment to
>>> identify the changes. Comment should reflect the purpose
>>> correctly. This would help Release Engineer to identify criticality
>>> and reason of each SR in OBS.
>>> For many of the SR Release Engineer cannot identify the purpose and he
>>> has to contact individually or trackback to identify the purpose.
>>> Going forward, if SR comment is not meaningful, I would suggest
>>> Release Engineer to reject those SR immediately.
>>According to [1] the submission should contain updates to the changlog.
>>Let's make those changes visible as SR comment.
> Backend service exposing content of annotation for submit tag to SR.
> E.g.:
> https://build.tizen.org/request/show/16481
> Submitter: Rusty Lynch <rusty.lynch at intel.com>
> Comments: Add a build config option for turning on journal logging
> Git project: platform/core/system/dlog
> Tag: submit/tizen/20131024.153312
> Commit: ac126309162b9bd470402571d7b7030dc3111d8c Update changelog
> $ git show submit/tizen/20131024.153312
> tag submit/tizen/20131024.153312
> Tagger: Rusty Lynch <rusty.lynch at intel.com>
> Date:   Thu Oct 24 08:33:12 2013 -0700
> Add a build config option for turning on journal logging
> commit ac126309162b9bd470402571d7b7030dc3111d8c
> ...
> So, as soon as maintainers put some meaningful comment into submit, it
> will be visible for release engineers.

That is not what I meant. I, as a developer, would like to have to write
as little as possible. If a submit request is generated only if a tag
points to a commit which updates packaging/*.changes (is it so?), then
it means I have to update the changlog to submit package for rebuild. If
there is some information that describes changes since previous
submission then why not put that automatically into submit request (or
create a script for REs to easily access this information let's see.

Let's take for example platform/upstream/cups.

--8<---------------cut here---------------start------------->8---
$ osc log Tizen:Mobile cups
r3 | hyungu | 2013-10-14 15:22:40 | 3b26e9c558eab6a5873a85edb09685c7 | 1.6.4 | rq15969

Submitter: GangHeok Kim <gangheok.kim at samsung.com>
Comments: Fixed build error based on 1.6.4
Git project: platform/upstream/cups
Tag: submit/tizen/20131014.104519
Commit: 542afd43930fc50ce563efe8e0d8ff78c77416e7 Update changelog
r2 | hyungu | 2013-09-12 10:59:51 | 9a7febb0095ce459ca4eee7bccbde2d3 | 1.5.3 | rq10548

Submitter: Graydon, Tracy <tracy.graydon at intel.com>
Comments: submit/tizen/20130912.075650
Git project: platform/upstream/cups
Tag: submit/tizen/20130912.075650
Commit: dc09fbdcc9c51ad0af3f81db3098609f4ffe4bf1 Update changelog
r1 | jang798 | 2013-08-29 09:32:47 | 5a79739f2a92bc92348fcdeda59ad98c | 1.5.3 | 

osc copypac from project:Tizen package:cups revision:3
$ git diff dc09fbdcc9c51ad0af3f81db3098609f4ffe4bf1..542afd43930fc50ce563efe8e0d8ff78c77416e7 packaging/cups.changes | sed -ne '/^@@/,$s/^+//p'
* Wed Oct 09 2013 Łukasz Stelmach <l.stelmach at samsung.com> upstream/1.6.4 at fe0f7d7
- Adapt packaging/cups.spec for 1.6.4

--8<---------------cut here---------------end--------------->8---

This is the whole store of changes between submissions. It has to be in
the *.changes file anyway. Why require anyone to type anything more?
The changelog information may be concatenated with the tag
annotiation to enable entering additional information if the same commit
is submitted (tagged) more than once.

>> [1] https://wiki.tizen.org/wiki/OSDev/Development_guide#How_to_trigger_submission_to_OBS
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.tizen.org/pipermail/dev/attachments/20131025/b87ee282/attachment.sig>

More information about the Dev mailing list