[Dev] Need a review on download-provider
casey.schaufler at intel.com
Wed Aug 13 16:59:59 GMT 2014
It looked reasonably harmless to me. A prompt follow-up fix should suffice.
From: Othman, Ossama [mailto:ossama.othman at intel.com]
Sent: Wednesday, August 13, 2014 9:56 AM
To: dev at lists.tizen.org; Schaufler, Casey
Subject: Re: [Dev] Need a review on download-provider
I just left some comments but the code was merged as I was writing them.
Casey, it looked like there was a TOCTOU race in one of the patches (https://review.tizen.org/gerrit/#/c/24123/3/provider-interface/download-provider-interface.c). Would you please confirm?
On Wed, Aug 13, 2014 at 9:40 AM, Stéphane Desneux <stephane.desneux at open.eurogiciel.org<mailto:stephane.desneux at open.eurogiciel.org>> wrote:
Casey did the review and merged the commit.
I submitted it on tizen_common. everything builds fine (including
tizen-extension-crosswalk). I think it's safe to accept it in the main
Thanks for the heads-up
Intel OTC - Vannes/FR
On 13/08/2014 17:09, corentin.lecouvey at open.eurogiciel.org<mailto:corentin.lecouvey at open.eurogiciel.org> wrote:
> Hi all,
> A code review is required on the following patch :
> This patch was proposed a month ago...
> It fixes many problems (64 bits, multiuser , smack, ... ) and make
> download API works over Crosswalk.
> For information, it also reinstalls 'net-config' by runtime dependency.
> Can anybody review this patch ?
> Thanks and regards,
> Dev mailing list
> Dev at lists.tizen.org<mailto:Dev at lists.tizen.org>
Dev mailing list
Dev at lists.tizen.org<mailto:Dev at lists.tizen.org>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Dev