[Dev] Need a review on download-provider

Stéphane Desneux stephane.desneux at open.eurogiciel.org
Wed Aug 13 17:46:26 GMT 2014


Ossama, can you please open a bug for this race condition ? Otherwise,
we may forget it...

Thanks !
-- 
Stéphane Desneux
Intel OTC - Vannes/FR
gpg:1CA35726/DFA9B0232EF80493AF2891FA24E3A2841CA35726

On 13/08/2014 18:56, Othman, Ossama wrote:
> I just left some comments but the code was merged as I was writing them.
> 
> Casey, it looked like there was a TOCTOU race in one of the patches
> (https://review.tizen.org/gerrit/#/c/24123/3/provider-interface/download-provider-interface.c).
>  Would you please confirm?
> 
> Thanks,
> -Ossama
> 
> 
> 
> On Wed, Aug 13, 2014 at 9:40 AM, Stéphane Desneux
> <stephane.desneux at open.eurogiciel.org
> <mailto:stephane.desneux at open.eurogiciel.org>> wrote:
> 
>     Casey did the review and merged the commit.
> 
>     I submitted it on tizen_common. everything builds fine (including
>     tizen-extension-crosswalk). I think it's safe to accept it in the main
>     project.
> 
>     Thanks for the heads-up
>     --
>     Stéphane Desneux
>     Intel OTC - Vannes/FR
>     gpg:1CA35726/DFA9B0232EF80493AF2891FA24E3A2841CA35726
> 
>     On 13/08/2014 17:09, corentin.lecouvey at open.eurogiciel.org
>     <mailto:corentin.lecouvey at open.eurogiciel.org> wrote:
>     > Hi all,
>     >
>     > A code review is required on the following patch :
>     > https://review.tizen.org/gerrit/#/c/24123/3
>     > This patch was proposed a month ago...
>     >
>     > It fixes many problems (64 bits, multiuser , smack, ... ) and make
>     > download API works over Crosswalk.
>     >
>     > For information, it also reinstalls 'net-config' by runtime
>     dependency.
>     >
>     > Can anybody review this patch ?
>     >
>     > Thanks and regards,
>     > Corentin
>     >
>     >
>     >
>     >
>     > _______________________________________________
>     > Dev mailing list
>     > Dev at lists.tizen.org <mailto:Dev at lists.tizen.org>
>     > https://lists.tizen.org/listinfo/dev
>     >
>     _______________________________________________
>     Dev mailing list
>     Dev at lists.tizen.org <mailto:Dev at lists.tizen.org>
>     https://lists.tizen.org/listinfo/dev
> 
> 
> 
> 
> _______________________________________________
> Dev mailing list
> Dev at lists.tizen.org
> https://lists.tizen.org/listinfo/dev
> 


More information about the Dev mailing list