[Dev] Gerrit reviews pending

Zofia Abramowska z.abramowska at samsung.com
Thu Aug 28 09:56:19 GMT 2014


Hi,

I see that there might be problem with not adding on review people who are
really responsible for the code.
I'm looking at libprivilege-control now, which had only external reviewers
(our team is
responsible for this package). I've added guys from our team now.
It would be the best to set at least one reviewer from recent committers as
for e.g. maintainers set for this
particular project don't represent who's really taking care of it (I am
aware it's partially our fault).
I don't personally like "threats" like below, when reviewers of commit are
not properly set.

And yes, I know that setting integrators/maintainers/reviewers should be
taken care by people responsible for 
the project (and as I see the problem now, we will try to make them
accurate), but setting at least one active 
reviewer (active in terms of recently committing to project) should not be a
big effort and will make whole 
communication/review/integration a lot easier and nicer.

Best regards,
Zofia Abramowska.

> -----Original Message-----
> From: Dev [mailto:dev-bounces at lists.tizen.org] On Behalf Of Dominig ar
> Foll (Intel OTC)
> Sent: Wednesday, August 27, 2014 3:19 PM
> To: dev at lists.tizen.org
> Subject: Re: [Dev] Gerrit reviews pending
> 
> Dear maintainer,
> 
> as this work needs to be done before the freeze of Yocto at the end of
> next week; I will have to force the patches acceptance if you have not
> taken any action.
> 
> Apologies for the push.
> 
> Dominig ar Foll
> Senior Software Architect
> Open Source Technology Centre
> Intel SSG
> 
> Le 27/08/2014 14:54, Kévin THIERRY a écrit :
> > Hi all,
> >
> > We are currently working on the Tizen build with Yocto and we made a
> > lot of small corrections in Tizen projects spec files. Those
> > corrections generally don't have any impact on the build/packaging
> > (using GBS) but make the spec files cleaner in order to generate
> > functional Yocto recipes.
> > We're having difficulties to get those changes reviewed, merged and
> > submitted so, can reviewer and maintainers of these projects look at
> > those changes please ?
> >
> > Here the list of the changes waiting to be reviewed/merged/submitted:
> >
> > * Merged NOT submitted on IVI
> >
> > automotive-message-broker https://review.tizen.org/gerrit/25138
> > libhangul https://review.tizen.org/gerrit/26241/
> >
> > * Merged NOT submitted
> >
> > alarm-manager https://review.tizen.org/gerrit/24113
> > appcore-agent https://review.tizen.org/gerrit/24380
> > application https://review.tizen.org/gerrit/24374
> > app-manager https://review.tizen.org/gerrit/24344
> > elementary https://review.tizen.org/gerrit/25047
> > ico-uxf-utilities https://review.tizen.org/gerrit/25102
> > libiri https://review.tizen.org/gerrit/20973
> > message-port https://review.tizen.org/gerrit/24383
> > pam https://review.tizen.org/gerrit/24958
> > privacy-manager https://review.tizen.org/gerrit/24064/
> > pwdutils https://review.tizen.org/gerrit/21024
> > xdgmime https://review.tizen.org/gerrit/24381
> >
> > * To review/merge
> >
> > audio-session-manager https://review.tizen.org/gerrit/24243
> > avsystem https://review.tizen.org/gerrit/24239
> > device https://review.tizen.org/gerrit/24341
> > dlog https://review.tizen.org/gerrit/24240
> > fdupes https://review.tizen.org/gerrit/23795/
> > genivi-audio-manager https://review.tizen.org/gerrit/26502/
> > gsignond https://review.tizen.org/gerrit/25405
> > ibus-hangul https://review.tizen.org/gerrit/26583
> > ibus-libpinyin https://review.tizen.org/gerrit/26580
> > ico-uxf-device-input-controller https://review.tizen.org/gerrit/25101
> > ico-uxf-homescreen https://review.tizen.org/gerrit/26510/
> > ico-uxf-homescreen-sample-apps https://review.tizen.org/gerrit/26307/
> > ico-uxf-weston-plugin https://review.tizen.org/gerrit/25104
> > ico-vic-carsimulator https://review.tizen.org/gerrit/26544/
> > image-util https://review.tizen.org/gerrit/25155
> > keyutils https://review.tizen.org/gerrit/25403
> > libgsignon-glib https://review.tizen.org/gerrit/25406
> > libmm-common https://review.tizen.org/gerrit/24410
> > libmm-fileinfo https://review.tizen.org/gerrit/24119
> > libmm-session https://review.tizen.org/gerrit/24232
> > libmm-ta https://review.tizen.org/gerrit/24228
> > libmm-utility https://review.tizen.org/gerrit/24342
> > libnet-client https://review.tizen.org/gerrit/24254
> > libpinyin https://review.tizen.org/gerrit/26555/
> > libprivilege-control https://review.tizen.org/gerrit/24508
> > libslp-pm https://review.tizen.org/gerrit/24378
> > libsvi https://review.tizen.org/gerrit/25389
> > libwebsockets https://review.tizen.org/gerrit/26326/
> > location-manager https://review.tizen.org/gerrit/24343
> > media-content https://review.tizen.org/gerrit/24385
> > media-server https://review.tizen.org/gerrit/24253
> > Modello_Installer https://review.tizen.org/gerrit/25098
> > power https://review.tizen.org/gerrit/24340
> > rpm https://review.tizen.org/gerrit/24957
> > sound-manager https://review.tizen.org/gerrit/24379
> > systemd https://review.tizen.org/gerrit/25163/
> > system-info https://review.tizen.org/gerrit/24382
> > update-desktop-files https://review.tizen.org/gerrit/26044/
> > user-session-units https://review.tizen.org/gerrit/24258
> > wav-player https://review.tizen.org/gerrit/25166
> >
> > Thanks,
> > Kevin
> > _______________________________________________
> > Dev mailing list
> > Dev at lists.tizen.org
> > https://lists.tizen.org/listinfo/dev
> 
> _______________________________________________
> Dev mailing list
> Dev at lists.tizen.org
> https://lists.tizen.org/listinfo/dev



More information about the Dev mailing list