[Dev] State of Pending changes , how to enhance workflow ? ( Was Dear Maintainers )
michael.demeter at intel.com
Mon Feb 3 16:25:39 GMT 2014
Actually many times it is the GBS submission process that never gets
completed. We typically have no problem(not in all cases) getting something
reviewed in gerrit. But after the +2 the it sits waiting for the maintainer
to do the gbs submit. So reviewed and accepted changes sit...
I actually prefer the gerrit submission process for review I just dislike
the following procedure..
On Feb 3, 2014 8:21 AM, "Schaufler, Casey" <casey.schaufler at intel.com>
> > -----Original Message-----
> > From: dev-bounces at lists.tizen.org [mailto:dev-bounces at lists.tizen.org]
> > Behalf Of Thiago Macieira
> > Sent: Monday, February 03, 2014 8:16 AM
> > To: dev at lists.tizen.org
> > Subject: Re: [Dev] State of Pending changes , how to enhance workflow ? (
> > Was Dear Maintainers )
> > Em seg 03 fev 2014, às 15:58:43, Schaufler, Casey escreveu:
> > > I'm sorry, I wasn't clear.
> > >
> > > Before the submit to gerrit the developer gets the code reviewed.
> > > The initial submit to gerrit includes the "Reviewed-by:" line.
> > > What I'm trying to say here is that the review is done first, then the
> > > submit. That way you don't get hung up waiting for a review.
> > Gerrit is the tool that people use to review. Asking people to review
> > submitting to the review tool sounds really awkward.
> If the tool in hand isn't suited to the job at hand it's time to
> put that tool down and pick up a different one.
> > --
> > Thiago Macieira - thiago.macieira (AT) intel.com
> > Software Architect - Intel Open Source Technology Center
> > _______________________________________________
> > Dev mailing list
> > Dev at lists.tizen.org
> > https://lists.tizen.org/listinfo/dev
> Dev mailing list
> Dev at lists.tizen.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Dev