[Dev] can't review a patch after rebasing

Chanho Park chanho61.park at samsung.com
Tue Oct 14 04:52:39 GMT 2014


Hi,

> -----Original Message-----
> From: Kanevskiy, Alexander [mailto:alexander.kanevskiy at intel.com]
> Sent: Tuesday, October 14, 2014 1:48 PM
> To: Chanho Park; Adam.Gretzinger at linux.intel.com
> Cc: dev at lists.tizen.org
> Subject: Re: [Dev] can't review a patch after rebasing
> 
> On 14/10/14 07:38 , "Chanho Park" <chanho61.park at samsung.com> wrote:
> 
> >Hi,
> >
> >> -----Original Message-----
> >> From: Kanevskiy, Alexander [mailto:alexander.kanevskiy at intel.com]
> >> Sent: Tuesday, October 14, 2014 1:12 PM
> >> To: Chanho Park; Adam.Gretzinger at linux.intel.com
> >> Cc: dev at lists.tizen.org
> >> Subject: Re: [Dev] can't review a patch after rebasing
> >>
> >> On 14/10/14 05:30 , "Chanho Park" <chanho61.park at samsung.com> wrote:
> >>
> >> >Hi,
> >> >
> >> >I found gerrit was upgraded to 2.9.1. Maintainer want to rebase the
> >> patch
> >> >sometimes if the patch is not on top of the latest commit. In this
> >>case,
> >> I
> >> >cannot review or submit the patch. Is this intended or bug?
> >> >
> >> >One more question:
> >> >When I reverted the old screen in my preference, I can't find
> 'review
> >> and
> >> >submit' button. Where is gone the button?
> >>
> >> Chanho,
> >>
> >> do you have example of change that you can’t review ? it would help
> to
> >> understand what doesn’t work as expected.
> >
> >Is there any change of policy about own patch which submitted by myself?
> >When I submitted my patch, I can't review and merge the patch even I
> was
> >maintainer. This rebase problem is same with the policy. Because when I
> >rebase a patch which is not on the latest commit, the patch will be
> >changed by me. So, we can't review the patch even the patch was posted
> by
> >me.
> 
> Even were v2.9.1 has ability to restrict certain rights for change
> owners
> (originator of the change), this option has been enabled only in one
> repository scm/meta/git.
> There are no other changes in ACLs for other projects.
> 
> So, any example of the change ID with which you have troubles would be
> good for investigation.

Ah, I misunderstood the new gerrit interface. I didn't know submit button is only available in case of +2.
Sorry for confusing.

Best Regards,
Chanho Park



More information about the Dev mailing list