[Tizen-submit] 3361: Changes to Tizen:2.1:Main/apps.Contacts

noreply at tizen.org noreply at tizen.org
Fri Apr 26 14:19:58 GMT 2013


Hi,
Jinkun Jang have made the following changes to apps.Contacts in project Tizen:2.1:Main. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #3361

  submit:       Tizen:2.1:Main:build/apps.Contacts(cleanup) -> Tizen:2.1:Main


Message:
Submitter: Jinkun Jang <jinkun.jang at samsung.com>
Comments: upload latest
Git project: apps/osp/Contacts
Tag: submit/tizen_2.1/20130426.142025
Commit: 450403b Fixed the jira issue.(N_SE-36456)

State:   new        2013-04-26T06:50:36 tizenrobot
Comment: <no comment>
spec files:
-----------
--- apps.Contacts.spec
+++ apps.Contacts.spec
@@ -2,7 +2,7 @@
 Summary:    Contacts application
 Version:    1.0.0.0
 Release:    1
-VCS:        apps/osp/Contacts#2.1_release-0-g4c70c5e
+VCS:        apps/osp/Contacts#submit/tizen_2.1/20130426.142025-0-g450403b
 Group:      TO_BE/FILLED_IN
 License:    TO BE FILLED IN
 Source0:    %{name}-%{version}.tar.gz

other changes:
--------------

++++++ apps.Contacts-1.0.0.0.tar.gz
--- /inc/CtContactDetailsForm.h
+++ /inc/CtContactDetailsForm.h
@@ -102,6 +102,7 @@
 	void CreateValueTypeItem(int itemWidth, Tizen::Ui::Controls::TableViewItem* pItem, const Tizen::Base::String& value, const Tizen::Base::String& type);
 	void CreateTitleValueTypeItem(int itemWidth, Tizen::Ui::Controls::TableViewItem* pItem, const Tizen::Base::String& title, const Tizen::Base::String& value, const Tizen::Base::String& type = L"", int lineCount = 1);
 	void CreateTitleValueTypeItem(int itemWidth, Tizen::Ui::Controls::TableViewItem* pItem, int detailProperty);
+	void CreateNoteItem(int itemWidth, Tizen::Ui::Controls::TableViewItem* pItem);
 
 	result LaunchAppControl(const Tizen::App::AppId& appId, const Tizen::Base::String& operationId, const Tizen::Base::String& launchType = L"", const Tizen::Base::String& value = L"");
 	result ParseAppControlArgument(const Tizen::Base::String& argument, Tizen::Base::String& type, Tizen::Base::String& content);
--- /inc/CtContactListPresentationModel.h
+++ /inc/CtContactListPresentationModel.h
@@ -96,7 +96,6 @@
 	Tizen::Base::Collection::ArrayList* _pContactChangeListenerList;
 	Tizen::Base::Collection::ArrayList* _pGroupIndexList;
 	Tizen::Social::Addressbook* _pAddressbook;
-	bool _isSearchingPhoneNumber;
 
 private:
 	Tizen::Base::Collection::IList* __pSearchedContactList;
--- /res/eng-GB.xml
+++ /res/eng-GB.xml
@@ -12,7 +12,7 @@
     <text id="IDS_COM_BODY_SELECT_ALL">Select all</text>
     <text id="IDS_COM_POP_CLOSE">Close</text>
     <text id="IDS_COM_POP_DELETE_Q">Delete?</text>
-    <text id="IDS_PB_OPT_ADD_TO_FAVORITES">Add to favorites</text>
+    <text id="IDS_PB_OPT_ADD_TO_FAVORITES">Add to favourites</text>
     <text id="IDS_PB_BODY_PHONE">Phone</text>
     <text id="IDS_COM_BODY_MESSAGE">Message</text>
     <text id="IDS_PB_BODY_LAST_NAME">Last name</text>
--- /src/CtContactDetailsForm.cpp
+++ /src/CtContactDetailsForm.cpp
@@ -253,6 +253,8 @@
 void
 ContactDetailsForm::OnActionPerformed(const Tizen::Ui::Control& source, int actionId)
 {
+	AppLog("ContactDetailsForm::OnActionPerformed(), actionId %d", actionId);
+
 	result r = E_SUCCESS;
 	SceneManager* pSceneManager = SceneManager::GetInstance();
 
@@ -1153,17 +1155,10 @@
 		break;
 	case DETAIL_PROPERTY_NOTE:
 		{
-			title = ResourceManager::GetString(L"IDS_PB_BODY_NOTE");
-			value = __pPresentationModel->GetValue(DETAIL_PROPERTY_NOTE);
-
-			TextBox* pNote = new (std::nothrow) TextBox();
-			pNote->Construct(Rectangle(0, 0, itemWidth - W_TEXT_MARGIN, itemHeight));
-			pNote->SetText(value);
-			lineCount = pNote->GetLineCount();
+			pItem->Construct(Dimension(itemWidth, itemHeight), TABLE_VIEW_ANNEX_STYLE_NORMAL);
+			CreateNoteItem(itemWidth, pItem);
 
-			delete pNote;
-
-			itemHeight += H_ADDITIONAL_ITEM * (lineCount - 1);
+			return;
 		}
 		break;
 	default:
@@ -1391,6 +1386,51 @@
 }
 
 void
+ContactDetailsForm::CreateNoteItem(int itemWidth, Tizen::Ui::Controls::TableViewItem* pItem)

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list