[Tizen-submit] 3373: Changes to Tizen:2.1:Main/apps.VideoPlayer

noreply at tizen.org noreply at tizen.org
Fri Apr 26 14:23:07 GMT 2013


Hi,
Jinkun Jang have made the following changes to apps.VideoPlayer in project Tizen:2.1:Main. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #3373

  submit:       Tizen:2.1:Main:build/apps.VideoPlayer(cleanup) -> Tizen:2.1:Main


Message:
Submitter: Jinkun Jang <jinkun.jang at samsung.com>
Comments: upload latest
Git project: apps/osp/VideoPlayer
Tag: submit/tizen_2.1/20130426.142334
Commit: d6a5eae Null check to avoid crash

State:   new        2013-04-26T06:53:45 tizenrobot
Comment: <no comment>
spec files:
-----------
--- apps.VideoPlayer.spec
+++ apps.VideoPlayer.spec
@@ -2,7 +2,7 @@
 Summary:    VideoPlayer application
 Version:    1.0.0
 Release:    1
-VCS:        apps/osp/VideoPlayer#2.1_release-0-g157df09
+VCS:        apps/osp/VideoPlayer#submit/tizen_2.1/20130426.142334-0-gd6a5eae
 Group:      TO_BE/FILLED_IN
 License:    TO BE FILLED IN
 Source0:    %{name}-%{version}.tar.gz

other changes:
--------------

++++++ apps.VideoPlayer-1.0.0.tar.gz
--- /src/VpVideoPlayerApp.cpp
+++ /src/VpVideoPlayerApp.cpp
@@ -88,7 +88,10 @@
 	AppLogDebug("SetFrameEnabled [%d]", enabled);
 
 	MainFrame* pMainFrame = dynamic_cast<MainFrame*>(GetFrameAt(0));
-	pMainFrame->SetEnabled(enabled);
+	if (pMainFrame != null)
+	{
+		pMainFrame->SetEnabled(enabled);
+	}
 }
 
 
@@ -227,6 +230,9 @@
 	}
 
 	MainFrame* pMainFrame = dynamic_cast<MainFrame*>(GetFrameAt(0));
-	pMainFrame->SetEnabled(true);
-	pMainFrame->Invalidate(true);
+	if (pMainFrame != null)
+	{
+		pMainFrame->SetEnabled(true);
+		pMainFrame->Invalidate(true);
+	}
 }
--- /src/VpVideoPlayerForm.cpp
+++ /src/VpVideoPlayerForm.cpp
@@ -76,7 +76,7 @@
 
 void DestroyPresentationModelInstance(void)
 {
-	delete VideoPlayerPresentationModel::GetInstance();
+	VideoPlayerPresentationModel::DestroyInstance();
 }
 
 VideoPlayerForm::VideoPlayerForm(void)
@@ -478,6 +478,8 @@
 	DeleteTimer();
 	DestroyPresentationModelInstance();
 
+	__pVideoPlayerPresentationModel = null;
+
 	RemoveControl(*__pOverlayPanel);
 	__pOverlayPanel = null;
 
@@ -497,6 +499,8 @@
 
 	AppLogDebug("OnSceneActivatedN");
 
+	TryReturnVoid(__pVideoPlayerPresentationModel != null, "__pVideoPlayerPresentationModel is null");
+
 	String totalTime;
 
 	CheckCallStatus();


More information about the Tizen-submit mailing list