[Tizen-submit] 18851: Changes to Tizen:Mobile/systemd

noreply at tizen.org noreply at tizen.org
Wed Dec 18 20:56:13 GMT 2013


Hi,
Patrick McCarty have made the following changes to systemd in project Tizen:Mobile. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #18851

  submit:       Tizen:Mobile:build/systemd(cleanup) -> Tizen:Mobile


Message:
Submitter: Patrick McCarty <patrick.mccarty at linux.intel.com>
Comments: logind: spawn user instance after saving user data; fixes a systemd logind race condition on bootup
Git project: platform/upstream/systemd
Tag: submit/tizen/20131218.205849
Commit: 6b31acecb8f412f7843951e6f3bacc7d8b516f42 Update changelog

State:   new        2013-12-18T20:53:45 tizenrobot
Comment: <no comment>
changes files:
--------------
--- systemd.changes
+++ systemd.changes
@@ -0,0 +1,4 @@
+* Tue Dec 17 2013 Patrick McCarty <patrick.mccarty at linux.intel.com> ae18bbe
+- logind: spawn user instance after saving user data; fixes a systemd logind
+  race condition on bootup (TIVI-2407)
+

new:
----
  0016-logind-spawn-user-instance-after-saving-user-data.patch

spec files:
-----------
--- systemd.spec
+++ systemd.spec
@@ -1,5 +1,5 @@
 Name:           systemd
-VCS:            platform/upstream/systemd#9ca6984bdbafdf25bfbd46953a631d0ede41b562
+VCS:            platform/upstream/systemd#6b31acecb8f412f7843951e6f3bacc7d8b516f42
 Version:        208
 Release:        0
 # For a breakdown of the licensing, see README
@@ -26,6 +26,7 @@
 Patch12:        0013-Set-Smack-netlabel-host-rules.patch
 Patch13:        0014-execute-add-SmackExecLabel-key-for-services.patch
 Patch14:        0015-user-.service-use-the-SmackExecLabel-key.patch
+Patch15:        0016-logind-spawn-user-instance-after-saving-user-data.patch
 BuildRequires:  gperf
 BuildRequires:  hwdata
 BuildRequires:  intltool >= 0.40.0
@@ -154,6 +155,8 @@
 %patch13 -p1
 # 0015-user-.service-use-the-SmackExecLabel-key.patch
 %patch14 -p1
+# 0016-logind-spawn-user-instance-after-saving-user-data.patch
+%patch15 -p1
 cp %{SOURCE1001} .
 
 %build

other changes:
--------------

++++++ 0016-logind-spawn-user-instance-after-saving-user-data.patch (new)
--- 0016-logind-spawn-user-instance-after-saving-user-data.patch
+++ 0016-logind-spawn-user-instance-after-saving-user-data.patch
@@ -0,0 +1,48 @@
+From: Patrick McCarty <patrick.mccarty at linux.intel.com>
+Date: Tue, 17 Dec 2013 23:50:53 -0800
+Subject: logind: spawn user instance after saving user data
+
+The RUNTIME variable from /run/systemd/users/UID may not be set by the
+time pam_systemd parses the variable to set XDG_RUNTIME_DIR.
+
+This race condition is affecting user at .service in that XDG_RUNTIME_DIR
+may be unset in the 'systemd --user' process, resulting in user services
+not inheriting the variable.
+
+Fix the issue by spawning user at .service *after* saving user data in
+user_start().
+
+Change-Id: Ib3108231655750dd2ea61024bd0ab700e0d1c93a
+Signed-off-by: Patrick McCarty <patrick.mccarty at linux.intel.com>
+---
+ src/login/logind-user.c |   10 +++++-----
+ 1 files changed, 5 insertions(+), 5 deletions(-)
+
+diff --git a/src/login/logind-user.c b/src/login/logind-user.c
+index adbe638..6bedf23 100644
+--- a/src/login/logind-user.c
++++ b/src/login/logind-user.c
+@@ -422,11 +422,6 @@ int user_start(User *u) {
+         if (r < 0)
+                 return r;
+ 
+-        /* Spawn user systemd */
+-        r = user_start_service(u);
+-        if (r < 0)
+-                return r;
+-
+         if (!dual_timestamp_is_set(&u->timestamp))
+                 dual_timestamp_get(&u->timestamp);
+ 

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list