[Tizen-submit] 6880: Changes to Tizen/vconf

noreply at tizen.org noreply at tizen.org
Thu Jun 27 19:30:14 GMT 2013


Hi,
Rusty Lynch have made the following changes to vconf in project Tizen. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #6880

  submit:       Tizen:build/vconf(cleanup) -> Tizen


Message:
Submitter: Rusty Lynch <rusty.lynch at intel.com>
Comments: fix systemd service file
Git project: platform/core/appfw/vconf
Tag: submit/tizen/20130627.192454
Commit: 5458f89 Remove ghost ref to nonexisting var-run.mount

State:   new        2013-06-27T12:27:13 tizenrobot
Comment: <no comment>
changes files:
--------------
--- vconf.changes
+++ vconf.changes
@@ -1,2 +1,2 @@
-* Tue Jun 04 2013 Xavier Roche <xavrock.os at gmail.com> submit/tizen/20130530.131328 at 9c7069c
-- Fix rpmlint issue
+* Thu Jun 27 2013 Rusty Lynch <rusty.lynch at intel.com> submit/tizen/20130620.090141 at 6700abc
+- Remove ghost ref to nonexisting var-run.mount
@@ -4,2 +4,3 @@
-* Thu May 30 2013 Baptiste DURAND <baptiste.durand at eurogiciel.fr> accepted/tizen/20130520.100940 at 6482fb5
-- Fix lib path in pc file and use _unitdir macro in spec file
+* Wed Jun 12 2013 Victor Hakoun <victor.hakoun at eurogiciel.fr> accepted/tizen/20130604.123334 at ee4fcd1
+- Fix possible memory leak
+- Fix string manipulation in x86_64 runtime

spec files:
-----------
--- vconf.spec
+++ vconf.spec
@@ -2,7 +2,7 @@
 Summary:    Configuration system library
 Version:    0.2.45
 Release:    3
-VCS:        platform/core/appfw/vconf#submit/tizen/20130604.095624-0-gc0b9f1b8f9b5dd480571f11ec2ed18c302a40592
+VCS:        platform/core/appfw/vconf#submit/tizen/20130627.192454-0-g5458f891a0e6f0ec412577f4eff026464f80fec8
 Group:      System/Libraries
 License:    Apache License, Version 2.0
 Source0:    %{name}-%{version}.tar.gz

other changes:
--------------

++++++ vconf-0.2.45.tar.gz
--- packaging/vconf-setup.service
+++ packaging/vconf-setup.service
@@ -2,8 +2,6 @@
 [Unit]
 Description=Initialize the VConf storage
 DefaultDependencies=no
-After=var-run.mount
-Requires=var-run.mount
 Before=basic.target
 
 [Service]
--- packaging/vconf.changes
+++ packaging/vconf.changes
@@ -1,5 +1,6 @@
-* Tue Jun 04 2013 Xavier Roche <xavrock.os at gmail.com> submit/tizen/20130530.131328 at 9c7069c
-- Fix rpmlint issue
+* Thu Jun 27 2013 Rusty Lynch <rusty.lynch at intel.com> submit/tizen/20130620.090141 at 6700abc
+- Remove ghost ref to nonexisting var-run.mount
 
-* Thu May 30 2013 Baptiste DURAND <baptiste.durand at eurogiciel.fr> accepted/tizen/20130520.100940 at 6482fb5
-- Fix lib path in pc file and use _unitdir macro in spec file
+* Wed Jun 12 2013 Victor Hakoun <victor.hakoun at eurogiciel.fr> accepted/tizen/20130604.123334 at ee4fcd1
+- Fix possible memory leak
+- Fix string manipulation in x86_64 runtime
--- vconf.c
+++ vconf.c
@@ -587,11 +587,11 @@
 
 int _vconf_get_key_prefix(const char *keyname, int *prefix)
 {
-	if (strncmp(keyname, BACKEND_DB_PREFIX, sizeof(BACKEND_DB_PREFIX) - 1) == 0) {
+	if (strncmp(keyname, BACKEND_DB_PREFIX, strlen(BACKEND_DB_PREFIX)) == 0) {
 		*prefix = VCONF_BACKEND_DB;
-	} else if (0 == strncmp(keyname, BACKEND_FILE_PREFIX, sizeof(BACKEND_FILE_PREFIX) - 1)) {
+	} else if (0 == strncmp(keyname, BACKEND_FILE_PREFIX, strlen(BACKEND_FILE_PREFIX))) {
 		*prefix = VCONF_BACKEND_FILE;
-	} else if (0 == strncmp(keyname, BACKEND_MEMORY_PREFIX, sizeof(BACKEND_MEMORY_PREFIX) - 1)) {
+	} else if (0 == strncmp(keyname, BACKEND_MEMORY_PREFIX, strlen(BACKEND_MEMORY_PREFIX))) {
 		*prefix = VCONF_BACKEND_MEMORY;
 	} else {
 		ERR("Invalid argument: wrong prefix of key(%s)", keyname);
@@ -604,11 +604,11 @@
 
 int _vconf_get_key_path(const char *keyname, char *path)
 {
-	if (strncmp(keyname, BACKEND_DB_PREFIX, sizeof(BACKEND_DB_PREFIX) - 1) == 0) {
+	if (strncmp(keyname, BACKEND_DB_PREFIX, strlen(BACKEND_DB_PREFIX)) == 0) {
 		snprintf(path, VCONF_KEY_PATH_LEN, "%s%s", BACKEND_SYSTEM_DIR, keyname);
-	} else if (0 == strncmp(keyname, BACKEND_FILE_PREFIX, sizeof(BACKEND_FILE_PREFIX) - 1)) {
+	} else if (0 == strncmp(keyname, BACKEND_FILE_PREFIX, strlen(BACKEND_FILE_PREFIX))) {
 		snprintf(path, VCONF_KEY_PATH_LEN, "%s%s", BACKEND_SYSTEM_DIR, keyname);
-	} else if (0 == strncmp(keyname, BACKEND_MEMORY_PREFIX, sizeof(BACKEND_MEMORY_PREFIX) - 1)) {

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list