[Tizen-submit] 5101: Changes to Tizen:2.1:Main/osp-shell

noreply at tizen.org noreply at tizen.org
Mon May 20 11:10:42 GMT 2013


Hi,
Jinkun Jang have made the following changes to osp-shell in project Tizen:2.1:Main. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #5101

  submit:       Tizen:2.1:Main:build/osp-shell(cleanup) -> Tizen:2.1:Main


Message:
Submitter: Jinkun Jang <jinkun.jang at samsung.com>
Comments: submit to obs
Git project: framework/osp/shell
Tag: submit/tizen_2.1/20130516.045712
Commit: 01f200d Modify doxygen

State:   accepted   2013-05-15T22:22:59 jang798
Comment: Please add a comment

History: new        2013-05-15T21:56:58 tizenrobot
spec files:
-----------
--- osp-shell.spec
+++ osp-shell.spec
@@ -5,7 +5,7 @@
 Summary:    The Shell library of OSP 
 Version:    1.2.1.0
 Release:    12
-VCS:        framework/osp/shell#submit/tizen_2.1/20130514.054256-0-gdca82e1
+VCS:        framework/osp/shell#submit/tizen_2.1/20130516.045712-0-g01f200d
 Group:      TO_BE/FILLED_IN
 License:    Apache License, Version 2.0 or Flora
 Source0:    %{name}-%{version}.tar.gz

other changes:
--------------

++++++ osp-shell-1.2.1.0.tar.gz
--- inc/FShellAppWidgetProvider.h
+++ inc/FShellAppWidgetProvider.h
@@ -87,7 +87,7 @@
 	 *
 	 *   Rectangle bounds = GetBounds();
 	 *   __pLabel->Construct(bounds, L"TIZEN");
-	 *   AddControl(*__pLabel);
+	 *   AddControl(__pLabel);
 	 *   this->SetAppWidgetFrame(pFrame);
 	 *   pFrame->Show();
 	 *
--- inc/FShellQuickPanelFrame.h
+++ inc/FShellQuickPanelFrame.h
@@ -95,7 +95,7 @@
 	pButton->Construct(Rectangle(10,10,200,80), L"Button");
 
 	// Adds the button to the QuickPanelFrame
-	__pQuickPanelFrame->AddControl(*pButton);
+	__pQuickPanelFrame->AddControl(pButton);
 	__pQuickPanelFrame->Show();
 
 	return r;
--- src/FShellAppWidgetProvider.cpp
+++ src/FShellAppWidgetProvider.cpp
@@ -60,12 +60,16 @@
 result
 AppWidgetProvider::SetAppWidgetFrame(AppWidgetFrame* pAppWidgetFrame)
 {
+	SysAssertf(__pAppWidgetProviderImpl != null, "Not yet constructed. The factory is called when AppWidgetProvider needs to be created. The SetAppWidgetProviderFactory() method should be called in App::OnAppInitializing(), to receive the event correctly. Implementing AppWidgetProviderFactory is mandatory to provide AppWidget functionality.");
+
 	return __pAppWidgetProviderImpl->SetAppWidgetFrame(pAppWidgetFrame);
 }
 
 AppWidgetFrame*
 AppWidgetProvider::GetAppWidgetFrame()
 {
+	SysAssertf(__pAppWidgetProviderImpl != null, "Not yet constructed. The factory is called when AppWidgetProvider needs to be created. The SetAppWidgetProviderFactory() method should be called in App::OnAppInitializing(), to receive the event correctly. Implementing AppWidgetProviderFactory is mandatory to provide AppWidget functionality.");
+
 	return __pAppWidgetProviderImpl->GetAppWidgetFrame();
 }
 
--- src/FShell_AppWidgetManagerProxy.cpp
+++ src/FShell_AppWidgetManagerProxy.cpp
@@ -19,6 +19,7 @@
  * @brief	This is the implementation for the _AppWidgetManagerProxy class.
  */
 
+#include <FBaseRt.h>
 #include <FIo_IpcClient.h>
 #include <FShell_AppWidgetManagerIpcMessage.h>
 #include "FShell_AppWidgetProviderManagerImpl.h"
@@ -82,8 +83,23 @@
 	__pIpcClient = new (std::nothrow) _IpcClient();
 	SysTryReturnResult(NID_SHELL, __pIpcClient != null, E_OUT_OF_MEMORY, "_IpcClient creation failed.");
 
-	result r = __pIpcClient->Construct(IPC_SERVER_NAME, this);
-	SysTryReturn(NID_SHELL, !IsFailed(r), r, r, "_IpcClient constructing failed [%s].", GetErrorMessage(r));
+	const int MAX_TRY_COUNT = 5;
+	const int TRY_SLEEP_TIME = 500;
+
+	int count = 0;
+	while (true)
+	{
+		result r = __pIpcClient->Construct(IPC_SERVER_NAME, this);
+		if (r == E_SUCCESS)
+		{

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list