[Tizen-submit] 6218: Changes to Tizen/pkgmgr

noreply at tizen.org noreply at tizen.org
Mon May 20 11:40:30 GMT 2013


Hi,
Anas Nashif have made the following changes to pkgmgr in project Tizen. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #6218

  submit:       Tizen:build/pkgmgr(cleanup) -> Tizen


Message:
Submitter: Anas Nashif <anas.nashif at intel.com>
Comments: do not hardcode library path
Git project: platform/core/appfw/slp-pkgmgr
Tag: submit/tizen/20130517.185027
Commit: a8c5788 do not hardcode library paths

State:   accepted   2013-05-17T19:41:16 nashif
Comment: Please add a comment

History: new        2013-05-17T19:40:55 tizenrobot
changes files:
--------------

spec files:
-----------
--- pkgmgr.spec
+++ pkgmgr.spec
@@ -2,7 +2,7 @@
 Summary:    Packager Manager client library package
 Version:    0.2.89
 Release:    1
-VCS:        platform/core/appfw/slp-pkgmgr#submit/tizen/20130517.181148-0-g73444fc
+VCS:        platform/core/appfw/slp-pkgmgr#submit/tizen/20130517.185027-0-ga8c5788
 Group:      System/Libraries
 License:    Apache-2.0
 Source0:    %{name}-%{version}.tar.gz
@@ -89,12 +89,15 @@
 %setup -q
 
 %build
-cmake . -DCMAKE_INSTALL_PREFIX=%{_prefix}
+%cmake . 
 make %{?jobs:-j%jobs}
 
 %install
 %make_install
-rm -rf  %{buildroot}%{_bindir}/pkgmgr_backend_sample
+rm -f  %{buildroot}%{_bindir}/pkgmgr_backend_sample
+rm -f %{buildroot}%{_libdir}/libpkgmgr_backend_lib_sample.so
+rm -f %{buildroot}%{_libdir}/libpkgmgr_parser_lib_sample.so
+
 
 
 %post
@@ -139,11 +142,9 @@
 %{_datadir}/packages/org.tizen.pkgmgr-install.xml
 %{_datadir}/mime/packages/mime.wac.xml
 %{_datadir}/mime/packages/mime.tpk.xml
-%{_libdir}/libpkgmgr_parser_lib_sample.so
 %exclude %{_includedir}/pkgmgr/comm_client.h
 %exclude %{_includedir}/pkgmgr/comm_config.h
 %exclude %{_includedir}/pkgmgr/comm_status_broadcast_server.h
-%exclude %{_libdir}/libpkgmgr_backend_lib_sample.so
 %exclude /usr/etc/package-manager/server/queue_status
 /etc/opt/upgrade/pkgmgr.patch.sh
 

other changes:
--------------

++++++ pkgmgr-0.2.89.tar.gz
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -13,7 +13,7 @@
 
 SET(PREFIX ${CMAKE_INSTALL_PREFIX})
 SET(EXEC_PREFIX "\${prefix}")
-SET(LIBDIR "\${prefix}/lib")
+SET(LIBDIR ${LIB_INSTALL_DIR})
 SET(INCLUDEDIR "\${prefix}/include")
 
 
@@ -88,10 +88,10 @@
 configure_file(pkg_path.conf.in pkg_path.conf @ONLY)
 configure_file(pkgmgr.patch.sh.in pkgmgr.patch.sh @ONLY)
 
-#INSTALL(FILES ${CMAKE_BINARY_DIR}/libpkgmgr-client.so DESTINATION lib)
-INSTALL(TARGETS ${PKGMGR_CLIENT} DESTINATION lib COMPONENT RuntimeLibraries)
+#INSTALL(FILES ${CMAKE_BINARY_DIR}/libpkgmgr-client.so DESTINATION ${LIB_INSTALL_DIR})
+INSTALL(TARGETS ${PKGMGR_CLIENT} DESTINATION ${LIB_INSTALL_DIR} COMPONENT RuntimeLibraries)
 INSTALL(FILES ${CMAKE_BINARY_DIR}/pkgmgr-server DESTINATION bin PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_WRITE)
-INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/pkgmgr.pc DESTINATION lib/pkgconfig)
+INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/pkgmgr.pc DESTINATION ${LIB_INSTALL_DIR}/pkgconfig)
 INSTALL(FILES ${CMAKE_CURRENT_SOURCE_DIR}/client/include/package-manager.h DESTINATION include)
 INSTALL(FILES ${CMAKE_CURRENT_SOURCE_DIR}/client/include/pkgmgr-dbinfo.h DESTINATION include)
 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/org.tizen.slp.pkgmgr.service DESTINATION ${PREFIX}/share/dbus-1/services/)
--- comm/CMakeLists.txt
+++ comm/CMakeLists.txt
@@ -136,7 +136,7 @@
 			pkgmgr_installer_client 
 			pkgmgr_installer_status_broadcast_server
 			pkgmgr_installer
-		DESTINATION lib
+            DESTINATION ${LIB_INSTALL_DIR}

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list