[Tizen-submit] 15264: Changes to Tizen:IVI:Release/chromium

noreply at tizen.org noreply at tizen.org
Wed Oct 2 01:56:48 GMT 2013


Hi,
Sunwook Bae have made the following changes to chromium in project Tizen:IVI:Release. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #15264

  submit:       Tizen:IVI:Release:build/chromium(cleanup) -> Tizen:IVI:Release


Message:
Submitter: Sunwook Bae <sunwook45.bae at samsung.com>
Comments: Fix a build error
Git project: platform/upstream/chromium
Tag: submit/tizen/20131002.015648
Commit: 3f7c0903daea1bba8d6f817ac077fe4ef8a238fb Fix a build error

State:   new        2013-10-02T01:55:11 tizenrobot
Comment: <no comment>
changes files:
--------------

spec files:
-----------
--- chromium.spec
+++ chromium.spec
@@ -2,8 +2,8 @@
 Summary:    Chromium Library
 Version:    1.0
 Release:    1
-VCS:        platform/upstream/chromium#submit/tizen/20130912.075631-0-gf4f90d9e380c1577b02ccdae29ca082fdd997385
-Group:      Web Framework/Libraries
+VCS:        platform/upstream/chromium#submit/tizen/20131002.015648-0-g3f7c0903daea1bba8d6f817ac077fe4ef8a238fb
+Group:      App Framework/Libraries
 License:    BSD-3-Clause
 Source0:    %{name}-%{version}.tar.gz
 Source1001: 	chromium.manifest
@@ -14,7 +14,7 @@
 
 %package devel
 Summary:    Chromium library - Development Files
-Group:      Development/Web Framework
+Group:      Development/App Framework
 Requires:   %{name} = %{version}-%{release}
 
 %description devel

other changes:
--------------

++++++ chromium-1.0.tar.gz
--- ipc/ipc_message_utils.h
+++ ipc/ipc_message_utils.h
@@ -962,7 +962,14 @@
   // those translation units.
   MessageWithTuple(int32 routing_id, uint32 type, const RefParam& p);
 
-  static bool Read(const Message* msg, Param* p) IPC_MSG_NOINLINE;
+  static bool Read(const Message* msg, Param* p)
+  { // Put definition into class so that Dispatch method could use it.
+    void* iter = NULL;
+    if (ReadParam(msg, &iter, p))
+      return true;
+    NOTREACHED() << "Error deserializing message " << msg->type();
+    return false;
+  } IPC_MSG_NOINLINE;
 
   // Generic dispatcher.  Should cover most cases.
   template<class T, class S, class Method>
@@ -1154,7 +1161,11 @@
 
   MessageWithReply(int32 routing_id, uint32 type,
                    const RefSendParam& send, const ReplyParam& reply);
-  static bool ReadSendParam(const Message* msg, SendParam* p) IPC_MSG_NOINLINE;
+  static bool ReadSendParam(const Message* msg, SendParam* p)
+  { // Put definition into class so that Dispatch method could use it.
+    void* iter = SyncMessage::GetDataIterator(msg);
+    return ReadParam(msg, &iter, p);
+  } IPC_MSG_NOINLINE;
   static bool ReadReplyParam(
       const Message* msg,
       typename TupleTypes<ReplyParam>::ValueTuple* p) IPC_MSG_NOINLINE;
--- ipc/ipc_message_utils_impl.h
+++ ipc/ipc_message_utils_impl.h
@@ -18,15 +18,6 @@
   WriteParam(this, p);
 }
 
-template <class ParamType>
-bool MessageWithTuple<ParamType>::Read(const Message* msg, Param* p) {
-  void* iter = NULL;
-  if (ReadParam(msg, &iter, p))
-    return true;
-  NOTREACHED() << "Error deserializing message " << msg->type();
-  return false;
-}
-
 // We can't migrate the template for Log() to MessageWithTuple, because each
 // subclass needs to have Log() to call Read(), which instantiates the above
 // template.
@@ -43,13 +34,6 @@
 }
 
 template <class SendParamType, class ReplyParamType>
-bool MessageWithReply<SendParamType, ReplyParamType>::ReadSendParam(

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list