[Tizen-submit] 16163: Changes to Tizen:IVI:Release/pulseaudio-module-murphy-ivi

noreply at tizen.org noreply at tizen.org
Wed Oct 16 13:50:21 GMT 2013


Hi,
Jaska Uimonen have made the following changes to pulseaudio-module-murphy-ivi in project Tizen:IVI:Release. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #16163

  submit:       Tizen:IVI:Release:build/pulseaudio-module-murphy-ivi(cleanup) -> Tizen:IVI:Release


Message:
Submitter: Jaska Uimonen <jaska.uimonen at helsinki.fi>
Comments: release: tagged release
Git project: profile/ivi/pulseaudio-module-murphy-ivi
Tag: submit/tizen/20131016.134712
Commit: 9b098f33307f41a668dd9e4931c4748d3a855670 updated changelog and pumped version number

State:   new        2013-10-16T13:48:54 tizenrobot
Comment: <no comment>
changes files:
--------------
--- pulseaudio-module-murphy-ivi.changes
+++ pulseaudio-module-murphy-ivi.changes
@@ -0,0 +1,4 @@
+* Wed Oct 16 17:53:12 EEST 2013 Janos Kovacs <jankovac503 at gmail.com> - 0.9.21
+- get rid of zombie combine modules
+- fixes TIVI-1965
+

old:
----
  pulseaudio-module-murphy-ivi-0.9.20.tar.gz

new:
----
  pulseaudio-module-murphy-ivi-0.9.21.tar.gz

spec files:
-----------
--- pulseaudio-module-murphy-ivi.spec
+++ pulseaudio-module-murphy-ivi.spec
@@ -1,8 +1,8 @@
 Summary: Pulseaudio module for enforcing policy decisions in the audio domain
 Name: pulseaudio-module-murphy-ivi
-Version:  0.9.20
+Version:  0.9.21
 Release: 0
-VCS:     profile/ivi/pulseaudio-module-murphy-ivi#submit/tizen/20131011.102655-0-g666b6ed4890e9281da8766d251676538b0d8198e
+VCS:     profile/ivi/pulseaudio-module-murphy-ivi#submit/tizen/20131016.134712-0-g9b098f33307f41a668dd9e4931c4748d3a855670
 License: LGPLv2.1
 Group: System Environment/Daemons
 URL: https://github.com/otcshare/pulseaudio-module-murphy-ivi

other changes:
--------------

++++++ pulseaudio-module-murphy-ivi-0.9.20.tar.gz -> pulseaudio-module-murphy-ivi-0.9.21.tar.gz
--- murphy/discover.c
+++ murphy/discover.c
@@ -823,8 +823,8 @@
     }
 }
 
-void pa_discover_preroute_sink_input(struct userdata *u,
-                                     pa_sink_input_new_data *data)
+pa_bool_t pa_discover_preroute_sink_input(struct userdata *u,
+                                          pa_sink_input_new_data *data)
 {
     pa_core           *core;
     pa_module         *m;
@@ -872,14 +872,14 @@
         if (loopback) {
             if (!(node = pa_utils_get_node_from_data(u, mir_input, data))) {
                 pa_log_debug("can't find loopback node for sink-input");
-                return;
+                return TRUE;
             }
 
             if (node->direction == mir_output) {
                 pa_log_debug("refuse to preroute loopback sink-input "
                              "(current route: sink %u @ %p)", data->sink ?
                              data->sink->index : PA_IDXSET_INVALID,data->sink);
-                return;
+                return TRUE;
             }
 
             data->sink = NULL;
@@ -922,18 +922,25 @@
 #endif
             if (pa_sink_input_new_data_set_sink(data, sink, FALSE))
                 pa_log_debug("set sink %u for new sink-input", sink->index);
-            else
+            else {
                 pa_log("can't set sink %u for new sink-input", sink->index);
+                                                      /* copes wit NULL mux */
+                pa_multiplex_destroy(u->multiplex, core, fake.mux);
+                return FALSE;
+            }
         }
     }
 
     if (loopback && data->sink && data->sink->module) {
+        /* no ramp needed */
         if (pa_streq(data->sink->module->name, "module-combine-sink"))
-            return;

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list