[Tizen-submit] 16504: Changes to Tizen:IVI/notification-service

noreply at tizen.org noreply at tizen.org
Fri Oct 25 17:51:29 GMT 2013


Hi,
Rusty Lynch have made the following changes to notification-service in project Tizen:IVI. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #16504

  submit:       Tizen:IVI:build/notification-service(cleanup) -> Tizen:IVI


Message:
Submitter: Rusty Lynch <rusty.lynch at intel.com>
Comments: Fix build warnings
Git project: profile/ivi/notification-service
Tag: submit/tizen/20131025.175040
Commit: 81d8b0c9e8437729b0838433673a4fc1c792f613 Fix build warnings

State:   new        2013-10-25T17:52:52 tizenrobot
Comment: <no comment>
changes files:
--------------
--- notification-service.changes
+++ notification-service.changes
@@ -0,0 +1,4 @@
+* Thu Oct 24 2013 Rusty Lynch <rusty.lynch at intel.com> accepted/tizen/20130920.213625 at 237321e
+- Fix build warnings by no longer using 'gets' and fixing the
+  prototype for notification callback
+

spec files:
-----------
--- notification-service.spec
+++ notification-service.spec
@@ -2,7 +2,7 @@
 Summary:    Simple notification service
 Version:    0.0.3
 Release:    1
-VCS:        profile/ivi/notification-service#submit/tizen/20130920.182450-0-g9a127c22d26a2c7524f4491c008b07c4a8add6cd
+VCS:        profile/ivi/notification-service#submit/tizen/20131025.175040-0-g81d8b0c9e8437729b0838433673a4fc1c792f613
 Group:      Application Framework/Notifications
 License:    Flora
 Source0:    %{name}-%{version}.tar.bz2

other changes:
--------------

++++++ notification-service-0.0.3.tar.bz2
--- bluetooth_notification_client.c
+++ bluetooth_notification_client.c
@@ -100,11 +100,12 @@
          notification_error_e err = NOTIFICATION_ERROR_NONE;
          int bt_yesno;
          bt_yesno = 1;
-         char line[256];
+         char line[4];
 
          fprintf(stdout, "Do you confirm yes or no ? ");
          while ( bt_yesno != 0){
-                 gets(line);
+                 if (!fgets(line, sizeof(line), stdin))
+                         continue;
                  if ( strcmp(line,"yes") == 0){
                          (cb_1) (proxy);
                          bt_yesno = 0;
@@ -122,7 +123,7 @@
 
 }
 
-static int __noti_changed_cb(void *data, notification_type_e type)
+static void __noti_changed_cb(void *data, notification_type_e type)
 {
          notification_h noti = NULL;
          notification_list_h notification_list = NULL;
@@ -180,13 +181,13 @@
                         sys_conn = dbus_g_bus_get(DBUS_BUS_SYSTEM, NULL);
                         if (sys_conn == NULL) {
                                 fprintf(stdout,"ERROR: Can't get on system bus");
-                                return EXIT_FAILURE;
+                                return;
                         }
 
                         agent_proxy = __bluetooth_create_agent_proxy(sys_conn, agent_path);
                         if (!agent_proxy){
                                 fprintf(stdout,"create new agent_proxy failed\n");
-                                return EXIT_FAILURE;
+                                return;
                         }
 
                          __display_notification(__notify_passkey_confirm_request_accept_cb, __notify_passkey_confirm_request_cancel_cb,agent_proxy);
@@ -205,13 +206,13 @@
                         sys_conn = dbus_g_bus_get(DBUS_BUS_SYSTEM, NULL);
                         if (sys_conn == NULL) {
                                 fprintf(stdout,"ERROR: Can't get on system bus");
-                                return EXIT_FAILURE;
+                                return;
                         }
 
                         agent_proxy = __bluetooth_create_agent_proxy(sys_conn, agent_path);
                         if (!agent_proxy){
                                 fprintf(stdout,"create new agent_proxy failed\n");
-                                return EXIT_FAILURE;
+                                return;
                         }
 
                         __display_notification( __notify_authorize_request_accept_cb, __notify_authorize_request_cancel_cb,agent_proxy);

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list