[Tizen-submit] 25446: Changes to Tizen:Mobile/tel-plugin-packetservice

noreply at tizen.org noreply at tizen.org
Tue Apr 8 08:07:37 GMT 2014


Hi,
Dongchul Lim have made the following changes to tel-plugin-packetservice in project Tizen:Mobile. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #25446

  submit:       Tizen:Mobile:build/tel-plugin-packetservice(cleanup) -> Tizen:Mobile


Message:
Submitter: Dongchul Lim <dc7.lim at samsung.com>
Comments: Initial refactoring merge
Git project: platform/core/telephony/tel-plugin-packetservice
Tag: submit/tizen/20140408.080614
Commit: 0e9b88a5e458e40187224136802332591ef0326c Initial refactoring merge

State:   new        2014-04-08T08:06:47 tizenrobot
Comment: <no comment>
old:
----
  tel-plugin-packetservice-0.1.34.tar.gz

new:
----
  tel-plugin-packetservice-3.0.1.tar.gz

spec files:
-----------
--- tel-plugin-packetservice.spec
+++ tel-plugin-packetservice.spec
@@ -1,7 +1,11 @@
+%define major 3
+%define minor 0
+%define patchlevel 1
+
 Name:       tel-plugin-packetservice
-VCS:        platform/core/telephony/tel-plugin-packetservice#767294d4521eb4f4f5d62e7233e7984ef862a756
+VCS:        platform/core/telephony/tel-plugin-packetservice#0e9b88a5e458e40187224136802332591ef0326c
 Summary:    Telephony Packet Service library
-Version:    0.1.34
+Version:    %{major}.%{minor}.%{patchlevel}
 Release:    1
 Group:      System/Libraries
 License:    Apache-2.0
@@ -10,13 +14,16 @@
 Requires(post): /sbin/ldconfig
 Requires(postun): /sbin/ldconfig
 BuildRequires:  cmake
+BuildRequires:  python
+BuildRequires:  python-xml
+BuildRequires:  pkgconfig(gio-2.0)
+BuildRequires:  pkgconfig(gio-unix-2.0)
 BuildRequires:  pkgconfig(glib-2.0)
-BuildRequires:  pkgconfig(dbus-glib-1)
-BuildRequires:  pkgconfig(dlog)
 BuildRequires:  pkgconfig(tcore)
 BuildRequires:  pkgconfig(iniparser)
 BuildRequires:  pkgconfig(libtzplatform-config)
-
+Requires(post): /sbin/ldconfig
+Requires(postun): /sbin/ldconfig
 %description
 Telephony Packet Service library
 

other changes:
--------------

++++++ tel-plugin-packetservice-0.1.34.tar.gz -> tel-plugin-packetservice-3.0.1.tar.gz
--- AUTHORS
+++ AUTHORS
@@ -1,6 +0,0 @@
-Jongman Park <jman.park at samsung.com>
-Ja-young Gu <jygu at samsung.com>
-Kyeongchul Kim <kyeongchul.kim at samsung.com>
-DongHoo Park <donghoo.park at samsung.>
-Youngman Park <youngman.park at samsung.com>
-Inho Oh <inho48.oh at samsung.com>
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -14,70 +14,62 @@
 
 # Set required packages
 INCLUDE(FindPkgConfig)
-pkg_check_modules(pkgs REQUIRED glib-2.0 dbus-glib-1 dlog tcore iniparser)
+pkg_check_modules(pkgs REQUIRED glib-2.0 gio-2.0 gio-unix-2.0 tcore libtzplatform-config iniparser)
 
 FOREACH(flag ${pkgs_CFLAGS})
 	SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${flag}")
 ENDFOREACH(flag)
 
-INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR}/include/)
+INCLUDE_DIRECTORIES(${CMAKE_SOURCE_DIR} ${CMAKE_SOURCE_DIR}/include/ ${CMAKE_SOURCE_DIR}/cmake_tmp )
 
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -Werror -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wdeclaration-after-statement -Wmissing-declarations -Wredundant-decls -Wcast-align")
-
-ADD_DEFINITIONS("-DFEATURE_DLOG_DEBUG")
-ADD_DEFINITIONS("-DTCORE_LOG_TAG=\"PACKETSERVICE\"")
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS}")
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wextra -fvisibility=hidden -fPIC")
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-unused-parameter -Wno-missing-field-initializers -Wdeclaration-after-statement -Wmissing-declarations -Wcast-align")
+
+### Purge unused code ###
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fdata-sections -ffunction-sections -Wl,--gc-sections")

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list