[Tizen-submit] 20802: Changes to Tizen:IVI/setup-ivi

noreply at tizen.org noreply at tizen.org
Fri Jan 31 14:42:45 GMT 2014


Hi,
Artem Bityutskiy have made the following changes to setup-ivi in project Tizen:IVI. Please review and accept ASAP.

Thank You,

[This message was auto-generated]

---

Request: #20802

  submit:       Tizen:IVI:build/setup-ivi(cleanup) -> Tizen:IVI


Message:
Submitter: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
Comments: Add splash screen entries (by Mikko Ylinen)
Git project: profile/ivi/setup-ivi
Tag: submit/tizen/20140131.144446
Commit: 3ca0137416551a040177517d2e46bca18d24ff3d packaging: update the changelog

State:   new        2014-01-31T14:44:37 tizenrobot
Comment: <no comment>
changes files:
--------------
--- setup-ivi.changes
+++ setup-ivi.changes
@@ -0,0 +1,5 @@
+* Fri Jan 31 2014 Artem Bityutskiy <artem.bityutskiy at linux.intel.com> 1.0
+- Generate kernel entries for debugging the splash screen work. These are
+  separate entries now, and only work for the gummiboot bloot-loader. Once
+  splash screen works well, it becomes part of the default boot entry.
+

spec files:
-----------
--- setup-ivi.spec
+++ setup-ivi.spec
@@ -1,5 +1,5 @@
 Name:     setup-ivi
-VCS:      profile/ivi/setup-ivi#bdd80cef5b70e702db135df02fa26e5cb60753fd
+VCS:      profile/ivi/setup-ivi#3ca0137416551a040177517d2e46bca18d24ff3d
 Version:  1.0
 Release:  1
 License:  GPL-2.0

other changes:
--------------

++++++ setup-ivi_1.0.tar.gz
--- README
+++ README
@@ -5,7 +5,8 @@
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 1. Do not use bashisms, install 'dash' and use it to verify that the
-   scripts are free of bashisms.
+   scripts are free of bashisms. Please, read this article:
+   https://wiki.ubuntu.com/DashAsBinSh
 
 2. Do not use all capitals for variables
 
@@ -21,5 +22,24 @@
    programming practice to make sure no one tricks your commands by adding
    options to what should be arguments. E.g., 'rm $file' can be made 'rm -rf /"
    if one makes "$file" to be "-rf /" somehow. 'rm -- $file' would catch this.
+
+7. Distinguish between options and arguments:
+       command --option1 --option2 argument1 argument2
+   Options are optional, do add "mandatory" options.
+   Arguments are mandatory, do not add optional arguments.
+
+8. Quote all the variables. This is important for everything which comes from
+   outside. But it is better to have this as a habit, jsut quote everything
+   starting with "$". Well, there exceptions sometimes, e.g., see how $verbose
+   is used. But these are rare. You can google for shell script attack vectors,
+   and notice that many of them are about giving tricky inputs with "$" signs,
+   spaces, and so on. Most of them are based on the fact that people do not
+   use quotes.
+
+9. Do not use "echo", use "printf". Well, "echo" is OK to use with "controlled"
+   data, but it is easier to just always use "printf" to maintain good
+   discipline. E.g., read this for some insight about why "printf" is safer:
+   http://unix.stackexchange.com/questions/65803/why-is-printf-better-than-echo
+
 --
 Artem Bityutskiy
--- packaging/setup-ivi.changes
+++ packaging/setup-ivi.changes
@@ -1,2 +1,7 @@
+* Fri Jan 31 2014 Artem Bityutskiy <artem.bityutskiy at linux.intel.com> 1.0
+- Generate kernel entries for debugging the splash screen work. These are
+  separate entries now, and only work for the gummiboot bloot-loader. Once
+  splash screen works well, it becomes part of the default boot entry.
+
 * Wed Jan 15 10:15:26 UTC 2014 Artem Bityutskiy <artem.bityutskiy at linux.intel.com> 1.0
 - Initial implementation.
--- setup-gummiboot-conf
+++ setup-gummiboot-conf
@@ -101,6 +101,9 @@
   -f, --force  if the entry already exists - re-write it, if
 	       <bootdir>/loader/loader.conf does not exist - create one,
 	       if <bootdir>/<kernel> does not exist - do not fail
+  -s, --splash <file>
+	       add a splash field to the entry file. <file> is a
+	       mandatory parameter to specify splash image location.
   -h, --help   show this text and exit
 EOF
 }

Please refer to OBS webUI for more details about this SR.


More information about the Tizen-submit mailing list